-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel bug lead to incorrect cpu usage #1300
kernel bug lead to incorrect cpu usage #1300
Conversation
|
Welcome @sleepyzhang! |
Hi @sleepyzhang. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm Can you backport to v0.6? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius, sleepyzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Please sign the CLA and add a test. |
/triage accepted |
…ead to cpu usage value is very large
f0c375b
to
82a7323
Compare
@serathius Does that mean I should mention a pr based on v0.6? |
@serathius How do i add a test? |
/retest |
/unhold |
/ok-to-test |
/lgtm |
/retest |
…rrect cpu usage
…rrect cpu usage
[release-0.6] cherrypick #1300 kernel bug lead to incorrect cpu usage
in one case,metrics-server will respons incorrect cpu usage,detailed description is as follows:
A StatefulSet pod named pod-0 used to run on a node named node1, this pod is then scheduled to run on node2,node1 has a kernel bug that causes the resource usage information of the pod-0 is stored,so when metrics-server pulls datas,which can pull pod-0 datas on node1 and node2, and drop node2's data, then when hpa controller gets pod-0 cpu usage will get a very large value,eg:pod-0 ran in node1 3 days ago,which used cpu accumulate 518400,and then pod-0 now running in node2 and used cpu accumulate 30, in this case, the calculated cpu usage is very large,the calcute way is described as follows:
so when calcute cpu usage,needing add a judge about data's collected timestamp